Add temporal-tool-registry module with AgenticSession support#2839
Open
lex00 wants to merge 5 commits intotemporalio:masterfrom
Open
Add temporal-tool-registry module with AgenticSession support#2839lex00 wants to merge 5 commits intotemporalio:masterfrom
lex00 wants to merge 5 commits intotemporalio:masterfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
|
|
|
Adds McpTool POJO and ToolRegistry.fromMcpTools static method that converts a list of MCP tool descriptors into a populated ToolRegistry. Handlers default to no-ops; callers override with register after construction. Null inputSchema is normalized to an empty object schema. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Set is_error=Boolean.TRUE on Anthropic tool result maps when a handler throws, matching the Anthropic API spec; OpenAI has no equivalent field - Add testAnthropicProvider_HandlerError_SetsIsError using an in-process HTTP server to verify is_error propagation without a real API key - Update README to clarify positioning vs Python/TypeScript framework plugins Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…out docs - Rename AgenticSession.issues → results, getIssues() → getResults(), addIssue() → addResult(); rename SessionCheckpoint JSON key 'issues' → 'results' - Remove unused system parameter from AgenticSession.runToolLoop and ToolRegistry.runToolLoop - Add ScheduleToCloseTimeout guidance to README - Update all test call sites Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The quickstart example used `issues` as the local collector variable, left over from before the AgenticSession field was renamed to `getResults()` in round 2. Rename to `results` so the example is consistent with the other SDK READMEs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
New
temporal-tool-registrymodule for running LLM tool-calling loops inside Temporal activities.ToolRegistry— maps tool names to JSON Schema definitions and handler functionsRunToolLoop— standalone tool loop, no Temporal worker requiredAgenticSession— crash-safe wrapper that checkpoints conversation history viaActivity.getExecutionContext().heartbeat()on each turn and restores on retry; session survives both activity crashes and provider-side session expiry since state is stored locallyAnthropicProviderandOpenAIProviderMockProviderandMockResponsefor unit testing without a live API keyToolRegistry.fromMcpTools— converts a list of MCP tool descriptors into a populated registryBug fix included
The Anthropic provider now sets
is_error: trueon tool result maps when a handler throws, matching the Anthropic API spec. A new test (testAnthropicProvider_HandlerError_SetsIsError) verifies this using an in-process HTTP server. OpenAI has no equivalent field.Why?
Temporal activities are a natural fit for LLM tool-calling loops, but every team reimplements the same boilerplate. This module standardizes the pattern across all six Temporal SDKs. Java has no framework-level LLM integration (Python's
openai_agents/google_adk_agentsand TypeScript's@temporalio/ai-sdkare Python/TypeScript only), so this is the recommended path for direct Anthropic/OpenAI calls in Java.Proposal: temporalio/proposals#107
Checklist
MockProvider(no API key required); integration tests against live Anthropic and OpenAI APIs gated onRUN_INTEGRATION_TESTS=1(skipped by default)